*: Use relative Jsonnet imports internally #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
reviewed
Aug 9, 2021
| @@ -1,5 +1,5 @@ | |||
| local receiveConfigDefaults = import 'kube-thanos/kube-thanos-receive-default-params.libsonnet'; | |||
| local receive = import 'kube-thanos/kube-thanos-receive.libsonnet'; | |||
| local receiveConfigDefaults = import './kube-thanos-receive-default-params.libsonnet'; | |||
There was a problem hiding this comment.
Or you can use full import path of github.com/thanos-io/kube-thanos/jsonnet/kube-thanos/kube-thanos-receive-default-params.libsonnet which is guaranteed to be correct and allows to ditch legacy imports in jsonnet-bundler.
There was a problem hiding this comment.
That is how I use the library, but why would you do that in the library?
And it is still not guaranteed to work, for example here how it is installed in the repo itself:
Lines 4 to 11 in e1a6859
It create
vendor/kube-thanos. It it not guarantee either that the user will use jb, especially that this library does not have any dependency. Another problematic case is if the user wants to use a fork, they need to rename those imports before being able to use it.
...and disable jb's legacy imports Signed-off-by: Maxime Brunet <maxime.brunet@paytm.com>
maxbrunet
force-pushed
the
feature/relative-imports
branch
from
2e6d0fc
to
9d344ab
Compare
|
@kakkoyun @metalmatze any concerns about merging this one if I rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
jb's legacy imports (not used, but making sure they are not accidentally used in the future)Reasons:
kube-thanos/is a valid import path for the end-userjb's legacy imports which are deprecatedVerification
CI passes.